Skip to content

[stable] 1.34.1 point release #60198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 25, 2019
Merged

[stable] 1.34.1 point release #60198

merged 6 commits into from
Apr 25, 2019

Conversation

pietroalbini
Copy link
Member

@pietroalbini pietroalbini commented Apr 23, 2019 •
edited by Mark-Simulacrum
Loading

The release date is April 25th.

Included in this point release:

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!
  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 23, 2019
@jonas-schievink
Copy link
Contributor

Would be nice to include the stable-accepted release notes fixes as well:

@pietroalbini
Copy link
Member Author

Good catch, added!

@Mark-Simulacrum
Copy link
Member

@bors r+ p=1000

@bors
Copy link
Collaborator

bors commented Apr 23, 2019

📌 Commit 34aed3d has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2019
@bors
Copy link
Collaborator

bors commented Apr 23, 2019

⌛ Testing commit 34aed3d with merge 51a0553fd41238b8a723b858c97ff7932acf189e...

@fortanix-bot

This comment has been minimized.

Sign in to view
@jethrogb

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Apr 24, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2019
@pietroalbini
Copy link
Member Author

Eeek?

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2019
@bors
Copy link
Collaborator

bors commented Apr 24, 2019

⌛ Testing commit 34aed3d with merge bb9f4bfb6497da2cfe2fb37a163caa8810a00d71...

@fortanix-bot

This comment has been minimized.

Sign in to view
@jonas-schievink
Copy link
Contributor

ImportError: No module named lldb

I had a similar error when running the tests on Arch Linux, for me the solution was to uninstall the system's LLDB. Not sure why this suddenly popped up on AppVeyor though.

@pietroalbini
Copy link
Member Author

Wtf? AppVeyor wasn't scheduled.

@bors retry

@pietroalbini
Copy link
Member Author

pietroalbini commented Apr 24, 2019 •
edited
Loading

@bors treeclosed-

AppVeyor said to have fixed the issue.

@bors
Copy link
Collaborator

bors commented Apr 24, 2019

⌛ Testing commit 34aed3d with merge 3ea00c5...

bors added a commit that referenced this pull request Apr 24, 2019
@bors
Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
3ea00c5 
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
@fortanix-bot

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Apr 24, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2019
@Mark-Simulacrum
Copy link
Member

Appveyor updated their build images on April 14th, which involved an LLVM upgrade (to 8) and Python upgrades: https://www.appveyor.com/updates/2019/04/14/. With the theory that this might be responsible for our troubles, I've pushed a commit downgrading to the "previous" image.

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 24, 2019

📌 Commit 9a8268e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2019
@bors
Copy link
Collaborator

bors commented Apr 24, 2019

⌛ Testing commit 9a8268e with merge 89a3797...

bors added a commit that referenced this pull request Apr 24, 2019
@bors
Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
89a3797 
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
@fortanix-bot

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Apr 24, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2019
@jethrogb
Copy link
Contributor

Same failure as before

@pietroalbini
Copy link
Member Author

I think the image: yaml key has to be at the top level, not inside environment:.

@bors r=Mark-Simulacrum p=1000

@bors
Copy link
Collaborator

bors commented Apr 24, 2019

📌 Commit d8a026d has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2019
bors added a commit that referenced this pull request Apr 24, 2019
@bors
Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
fc50f32 
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
@bors
Copy link
Collaborator

bors commented Apr 24, 2019

⌛ Testing commit d8a026d with merge fc50f32...

@fortanix-bot
Copy link

Build failed for target x86_64-fortanix-unknown-sgx - status

cc @jethrogb

@bors
Copy link
Collaborator

bors commented Apr 25, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing fc50f32 to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 25, 2019
@bors bors merged commit d8a026d into rust-lang:stable Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@pietroalbini @rust-highfive @jonas-schievink @Mark-Simulacrum @bors @fortanix-bot @jethrogb @cuviper @dima74